Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add CI workflow to do local scratch deployment #807

Merged
merged 20 commits into from
Dec 7, 2023
Merged

Add CI workflow to do local scratch deployment #807

merged 20 commits into from
Dec 7, 2023

Conversation

arwer13
Copy link
Contributor

@arwer13 arwer13 commented Nov 22, 2023 •
edited
Loading

The general purpose is to keep the scratch deployment scripts alive and sound - this PR is the first iteration.

Namely it add github workflow which spawns local clean anvil node and runs local scratch deploy script and scratch-acceptance-test script on it.

Also:

  • ⚠️ add MANAGE_NODE_OPERATOR_ROLE to Agent (as it is on mainnet) upon deployment to simplify and don't add voting-related code to scratch-acceptance-test.
  • bump github actions:
    • checkout v3 -> v4
    • setup-node v3 -> v4
  • bump NodeJS version 16 -> 18
  • fix running the simple acceptance test when forking a local debug node (anvil/hardhat/...)
  • fix storage-layout action check
  • fix assert-bytecode action check. NB: Bytecode checks are disabled in the last commit (as they were, because they are supposed to be enabled only for PRs to master ). To see the result see CI checks at the previous commit a0dcbdf
  • remove obsolete github flow
  • remove artifacts.json and do generate it only on CI in the corresponding action

@TheDZhon
Copy link
Contributor

Huge 👓

@arwer13
try forge github action to run anvil (#808)
b50aade 
feat(CI): add flow to scratch deploy on clean local anvil
@arwer13 arwer13 marked this pull request as ready for review November 23, 2023 10:47
@arwer13
refactor: CI anvil run command and missing debug output
986869f
@arwer13
doc(scratch-deploy): local deploy: remove accounts.json setup step
9f13999
@arwer13
feat(scratch): after deploy run simple acceptance test (on fork)
124bfd2
@arwer13
feat: on scratch deploy grant NOR's MANAGE_NODE_OPERATOR_ROLE to voting
8becfe6 
Need this to make current scratch acceptance script work.
After voting utilities added to the repo can rewrite the acceptance
script to grant/renounce this role.
@arwer13
refactor(github flows): remove obsolete files
43aaa74
@arwer13
fix(github flow): attempt to fix bytecode checks (assert-bytecode.yml)
dfe71bd
@arwer13
refactor: generate artifacts.json on CI, remove it from repo and compile
abf0b8b
@arwer13
fix(workflows): typo in assert-bytecode.yml
fb8c68b
@arwer13
fix(workflows): attemp to fix storage-layout updating the action used
8581569
@arwer13
fix(workflow): attempt to fix assert-bytecode (ignore LidoTemplate)
fea112c
@arwer13
fix(workflow): 2nd attempt to fix assert-bytecode (ignore LidoTemplate)
1c57abe
@arwer13
fix(workflow storage-layout-check): ignore ERC1967Proxy
6831106
@arwer13
fix(workflow): 3rd attempt to fix assert-bytecode (restore ignores)
0801db3
@arwer13 arwer13 mentioned this pull request Nov 28, 2023
Open
TheDZhon
TheDZhon approved these changes Nov 29, 2023
View reviewed changes
Copy link
Contributor

@TheDZhon TheDZhon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, a single comment only is to consider 🙏

contracts/0.4.24/template/LidoTemplate.sol Outdated Show resolved Hide resolved
TheDZhon
TheDZhon approved these changes Dec 6, 2023
View reviewed changes
Copy link
Contributor

@TheDZhon TheDZhon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@arwer13 arwer13 merged commit c5a5797 into develop Dec 7, 2023
6 checks passed
@arwer13 arwer13 deleted the feat/ci-scratcy-deploy branch December 7, 2023 08:48
@arwer13 arwer13 mentioned this pull request Dec 7, 2023
Merged
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@madlabman madlabman madlabman approved these changes

@TheDZhon TheDZhon TheDZhon approved these changes

@folkyatina folkyatina Awaiting requested review from folkyatina

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@arwer13 @TheDZhon @madlabman